-
Notifications
You must be signed in to change notification settings - Fork 732
chore: support go 1.24 #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support go 1.24 #1304
Conversation
@microsoft-github-policy-service agree |
@m1ngyuan I stumbled across this PR as I am also waiting for the 1.24 devcontainer. I think there bullseye sections in the manifest fie also need additions for version 1.24. Or do I miss something here? |
Any updates on this? When can we expect this to be merged and the go1.24 images to be published on MCR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I left a couple of minor comments, but otherwise this looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡ Thanks for adding this!
Nice! When can we expect mcr.microsoft.com/devcontainers/go:1.24-bookworm to be published? |
It seems like the update made to the README file is not very accurate, give the version stays - - `mcr.microsoft.com/devcontainers/go:1.2-1.23` (or `1.2-1.23-bookworm`, `1.2-1.23-bullseye`)
+ - `mcr.microsoft.com/devcontainers/go:1.4-1.24` (or `1.4-1.24-bookworm`, `1.4-1.24-bullseye`) |
fyi: need to add devcontainer.json: found looking at tags here: https://mcr.microsoft.com/en-us/artifact/mar/devcontainers/go/tags |
Add support for go 1.24 as released https://go.dev/doc/go1.24