Skip to content

Conversation

m1ngyuan
Copy link
Contributor

Add support for go 1.24 as released https://go.dev/doc/go1.24

@m1ngyuan
Copy link
Contributor Author

@microsoft-github-policy-service agree

@m1ngyuan m1ngyuan marked this pull request as ready for review February 13, 2025 12:23
@m1ngyuan m1ngyuan requested a review from a team as a code owner February 13, 2025 12:23
@lechnerc77
Copy link

@m1ngyuan I stumbled across this PR as I am also waiting for the 1.24 devcontainer. I think there bullseye sections in the manifest fie also need additions for version 1.24. Or do I miss something here?

@mnafees
Copy link

mnafees commented Feb 20, 2025

Any updates on this? When can we expect this to be merged and the go1.24 images to be published on MCR?

Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I left a couple of minor comments, but otherwise this looks good

Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ Thanks for adding this!

@ddoyle2017 ddoyle2017 merged commit 4828efe into devcontainers:main Feb 25, 2025
2 checks passed
@m1ngyuan m1ngyuan deleted the go1.24 branch February 26, 2025 04:21
@psalaberria002
Copy link

Nice! When can we expect mcr.microsoft.com/devcontainers/go:1.24-bookworm to be published?

@criyle
Copy link
Contributor

criyle commented Feb 26, 2025

It seems like the update made to the README file is not very accurate, give the version stays 1.3.3.

- - `mcr.microsoft.com/devcontainers/go:1.2-1.23` (or `1.2-1.23-bookworm`, `1.2-1.23-bullseye`)
+ - `mcr.microsoft.com/devcontainers/go:1.4-1.24` (or `1.4-1.24-bookworm`, `1.4-1.24-bullseye`)

@aerth
Copy link

aerth commented Feb 27, 2025

fyi: need to add dev- prefix to use this latest image version (not sure how long until it moves...)

devcontainer.json: "image": "mcr.microsoft.com/devcontainers/go:dev-1.24-bookworm",

found looking at tags here: https://mcr.microsoft.com/en-us/artifact/mar/devcontainers/go/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants