Suggestion about findComposeContainer

[NerdToMars]

It's a bit inadequate to search docker container only with project name and services when project name is the basename of the working directory.

cli/src/spec-node/dockerCompose.ts

Line 613 in 71180e7

`${projectLabel}=${projectName}`,

Can I suggest to either use longer name for project:

cli/src/spec-node/dockerCompose.ts

Lines 643 to 645 in 71180e7

	return toProjectName(`${cliHost.path.basename(configDir)}_devcontainer`, newProjectName);
	}
	return toProjectName(cliHost.path.basename(workingDir), newProjectName);

like replace the use of basename with a representation of the full path where each subdirectory is connected with an underscore (_)

function pathToUnderscore(p: string): string {
    return p.split(path.sep).join('_');
}

...
...

if (equalPaths(cliHost.platform, workingDir, cliHost.path.join(configDir, '.devcontainer'))) {
    return toProjectName(`${pathToUnderscore(configDir)}_devcontainer`, newProjectName);
}
return toProjectName(pathToUnderscore(workingDir), newProjectName);

[samruddhikhandale]

Hi 👋

Thanks for the suggestion, it makes sense to me.

@NerdToMars would you be interested in contributing the change to the CLI? We appreciate support from the community, thanks!

[NerdToMars]

or is it possible to add more filter in findComposeContainer function

like filter based on devcontainer.local_folder

[chrmarti]

This is how Docker Compose identifies containers. We can't change that.