Skip to content

Add record_ecosystem_meta entries to smoke test expectations#389

Merged
pavera merged 3 commits intomainfrom
copilot/update-smoke-tests-default-behavior
Mar 4, 2026
Merged

Add record_ecosystem_meta entries to smoke test expectations#389
pavera merged 3 commits intomainfrom
copilot/update-smoke-tests-default-behavior

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 4, 2026

dependabot-core PR #14353 removes the enable_record_ecosystem_meta feature flag, making record_ecosystem_meta unconditionally active. This causes all smoke tests to fail because the output stream now contains record_ecosystem_meta messages that aren't in the expectation files.

  • Added record_ecosystem_meta entries after every create_pull_request, update_pull_request, and close_pull_request output entry across 78 test files
  • Ecosystem metadata (name, package_manager, language) derived from actual CI failure diffs on the core PR

Example entry added after each PR operation:

    - type: record_ecosystem_meta
      expect:
        data:
            - ecosystem:
                name: bundler
                package_manager:
                    name: bundler
                    version: 2.7.2
                    raw_version: 2.7.2

Ecosystems with language info (cargo, composer, go_modules, npm_and_yarn, etc.) include the additional language block. Ecosystems without runtime language detection (docker, github_actions, terraform, etc.) omit it.

Original prompt

This section details on the original issue you should resolve

<issue_title>Update smoke tests to conform with new default behavior</issue_title>
<issue_description>We are removing the enable_record_ecosystem_meta feature flag which means the default behavior of dependabot-core has changed. Update the expectation files in the smoke tests to match the new behavior.
</issue_description>

Comments on the Issue (you are @copilot in this section)

  • Fixes github/dependabot-updates#12647

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits March 4, 2026 16:18
The enable_record_ecosystem_meta feature flag in dependabot-core is being
removed, making record_ecosystem_meta unconditionally active. After every
create_pull_request, update_pull_request, or close_pull_request call, a
record_ecosystem_meta message is now emitted.

This adds the expected record_ecosystem_meta entries after each such
output entry in all 80 affected smoke test YAML files, with the correct
ecosystem data for each package manager.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
After each create_pull_request, update_pull_request, or close_pull_request
output entry, add a record_ecosystem_meta entry with the correct ecosystem
metadata. This is needed because the enable_record_ecosystem_meta feature
flag is being removed from dependabot-core, making record_ecosystem_meta
unconditionally active.

Co-authored-by: pavera <660677+pavera@users.noreply.github.com>
Copilot AI changed the title [WIP] Update smoke tests for new default behavior Add record_ecosystem_meta entries to smoke test expectations Mar 4, 2026
@pavera
Copy link
Copy Markdown
Contributor

pavera commented Mar 4, 2026

This will pass/be mergeable once dependabot/dependabot-core#14353 merges.

@pavera pavera marked this pull request as ready for review March 4, 2026 16:37
@pavera pavera requested review from a team as code owners March 4, 2026 16:37
@pavera pavera enabled auto-merge March 4, 2026 18:50
@pavera pavera merged commit d532fb7 into main Mar 4, 2026
34 of 443 checks passed
@pavera pavera deleted the copilot/update-smoke-tests-default-behavior branch March 4, 2026 19:20
@jayaddison
Copy link
Copy Markdown

I think that some of the e2e smoke test failures for the v0.364.0 dependabot-core release (pull request dependabot/dependabot-core#14366) seem to be related to this change.

Although multiple ecosystems failed during the smoke tests, here's one example build log reference for Python/pip since that's what I'm most familiar with personally: https://github.com/dependabot/dependabot-core/actions/runs/22699005065/job/65811737594#step:10:389

kbukum1 added a commit that referenced this pull request Mar 5, 2026
…tests-default-behavior"

This reverts commit d532fb7, reversing
changes made to 87d9e61.
@kbukum1 kbukum1 mentioned this pull request Mar 5, 2026
kbukum1 added a commit that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants