Add record_ecosystem_meta entries to smoke test expectations#389
Merged
Add record_ecosystem_meta entries to smoke test expectations#389
Conversation
The enable_record_ecosystem_meta feature flag in dependabot-core is being removed, making record_ecosystem_meta unconditionally active. After every create_pull_request, update_pull_request, or close_pull_request call, a record_ecosystem_meta message is now emitted. This adds the expected record_ecosystem_meta entries after each such output entry in all 80 affected smoke test YAML files, with the correct ecosystem data for each package manager. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
After each create_pull_request, update_pull_request, or close_pull_request output entry, add a record_ecosystem_meta entry with the correct ecosystem metadata. This is needed because the enable_record_ecosystem_meta feature flag is being removed from dependabot-core, making record_ecosystem_meta unconditionally active. Co-authored-by: pavera <660677+pavera@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update smoke tests for new default behavior
Add record_ecosystem_meta entries to smoke test expectations
Mar 4, 2026
Contributor
|
This will pass/be mergeable once dependabot/dependabot-core#14353 merges. |
jakecoffman
approved these changes
Mar 4, 2026
kbukum1
approved these changes
Mar 4, 2026
JamieMagee
approved these changes
Mar 4, 2026
|
I think that some of the e2e smoke test failures for the v0.364.0 Although multiple ecosystems failed during the smoke tests, here's one example build log reference for Python/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependabot-core PR #14353 removes the
enable_record_ecosystem_metafeature flag, makingrecord_ecosystem_metaunconditionally active. This causes all smoke tests to fail because the output stream now containsrecord_ecosystem_metamessages that aren't in the expectation files.record_ecosystem_metaentries after everycreate_pull_request,update_pull_request, andclose_pull_requestoutput entry across 78 test filesExample entry added after each PR operation:
Ecosystems with language info (cargo, composer, go_modules, npm_and_yarn, etc.) include the additional
languageblock. Ecosystems without runtime language detection (docker, github_actions, terraform, etc.) omit it.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.