Merged
Conversation
Keeping back in `"es6"` is causing an issue over in a Dependabot PR where another library wants to use newer Javascript features. The reason `"es6"` was the previous target is because GitHub actions used to use node 12, which didn't support some of the newer versions. But now that GitHub Actions is on Node 20, which supports `"es2022"`, it's safe to let Typescript compile using this much newer syntax.
honeyankit
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping back in
es6is causing an issue over in a Dependabot PR where another library wants to use newer Javascript features.The reason
es6was the previous target is because GitHub actions used to usenode12, which didn't support some of the newer versions.But GitHub Actions is now on
node20, which supportses2022, so it's safe to let Typescript compile using this much newer syntax.