Fix Vint version detection#5138
Open
letorbi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken Vint version detection due to Python warnings that interfere with ALE's version detection algorithm.
I discovered that my Vint based Vim Script linting did not work anymore and was able to track it down to a new Python version (3.14) that has been installed on my system recently. The reason is the
pkg_resourcesAPI, which is still used by the last stable Vint version (0.3.21), but has been declared as obsolete for a longer time now.This causes
vint --versionto return the following:ALE's semver module parses this as
[3, 14, 0], possibly due topython3.14in the first line. Since ALE assumes that this version of Vint has stdin support, it calls Vint with the--stdin-display-nameoption, which is not yet available in Vint 0.3.21.This PR changes the call to print Vint's version from just
vint --versiontoPYTHONWARNINGS=ignore vint --version. This suppresses all Python warnings and thus allows ALE's semver module to detect the correct version.