Skip to content

chore(node): update version to 18.12.1 #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Conversation

lino-levan
Copy link
Contributor

These changes were obtained by running in node 18.12.0

const { versions } = require('node:process');

console.log(versions)

Closes #3057

@lino-levan
Copy link
Contributor Author

Now that I think about it, do we want to be targeting 18.12.1? The OpenSSL security issue is patched in it.

@lino-levan lino-levan changed the title fix(node/process): update version to 18.12.0 fix(node/process): update version to 18.12.1 Dec 26, 2022
@lino-levan lino-levan changed the title fix(node/process): update version to 18.12.1 chore(node): update version to 18.12.1 Dec 26, 2022
@@ -100,7 +100,7 @@ export const platform = isWindows ? "win32" : Deno.build.os;
* it pointed to Deno version, but that led to incompability
* with some packages.
*/
export const version = "v16.17.0";
export const version = "v18.12.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kt3k
Copy link
Member

kt3k commented Dec 27, 2022

The update to v18.12.1 also makes sense to me.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 3287be3 into denoland:main Dec 27, 2022
@lino-levan lino-levan deleted the fix-node-version branch December 28, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node: process.version gives v16.17.0 instead of v18.x
2 participants