Skip to content

Conversation

@vwong
Copy link
Contributor

@vwong vwong commented Jan 30, 2025

No description provided.

Copy link
Contributor

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vwong
Copy link
Contributor Author

vwong commented Jan 30, 2025

Updated.. Is this what you mean?

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm
Copy link
Contributor

Eomm commented Jan 31, 2025

Updated.. Is this what you mean?

Yes, but the CI fails with this error now:

  test/types/router.test-d.ts:20:37
  ✖  20:37  => expected.  
  ✖  96:37  => expected.  

@vwong
Copy link
Contributor Author

vwong commented Jan 31, 2025

Ah, sorry I was coding blind for a while, because I couldn't manage to run the test locally with my local version of node 20.. When I switched to node 22, I was able to reproduce the error in CI, and fixed it. Should be good now.

@vwong
Copy link
Contributor Author

vwong commented Jan 31, 2025

Sorry for the back and forth...

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vwong
Copy link
Contributor Author

vwong commented Feb 5, 2025

Any chance we can release this?

@mcollina mcollina merged commit e9410f7 into delvedor:main Feb 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants