feat(route): return route params on findRoute #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerio-pizzichini
force-pushed
the
feature/return-route-params-on-find-route
branch
from
e52b573 to
0d92457
Compare
mcollina
reviewed
Jan 5, 2024
Collaborator
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
good work!
Can you add some docs?
Contributor
Author
Added the returned params on the already present |
ivan-tymoshenko
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #341
The goal of this PR is to add dev params to the object returned from the
Router.findRoutemethod as we do on theRouter.find.