Skip to content

Conversation

@ghthor
Copy link
Contributor

@ghthor ghthor commented Apr 8, 2025

What Changed

  1. utilize docker cache volumes during builds to slightly improve performance
  2. set runtime image to same base image distro as the build image

Why

1. cache volumes

A clean build on my local machine takes about 30 mins. This is an attempt to
improve the iteration process by reducing the scope of changes that blow the
docker build cache and using docker volumes for large sections of the image that
are written during cargo build reducing recompilation of dependencies during
every docker build.

2. debian runtime

The binary produced in by the rust image doesn't run inside the alpine
container. This switches the runtime of the final image to match the upstream
base image of the rust image that is used to build.

@ghthor ghthor force-pushed the dockerfile-improvements branch from 063febe to a7606c4 Compare April 8, 2025 00:14
@ghthor ghthor marked this pull request as ready for review April 8, 2025 15:14
@rtyler rtyler enabled auto-merge (rebase) April 8, 2025 22:58
Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've validated it insofar as I can, we have some other build failures on main which are unrelated.

@rtyler rtyler disabled auto-merge April 8, 2025 23:27
@rtyler rtyler merged commit a4e8d4a into delta-io:main Apr 8, 2025
1 of 3 checks passed
@ghthor ghthor deleted the dockerfile-improvements branch April 9, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants