Skip to content

TimeoutException in search #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2018
Merged

TimeoutException in search #30

merged 3 commits into from
Nov 28, 2018

Conversation

nguyenLisa
Copy link
Member

Undeterministically generates a harmless error message from Akka in the console (akka/akka-http#497). Future work: disable this message.
@ghost ghost assigned nguyenLisa Nov 24, 2018
@ghost ghost added the review label Nov 24, 2018
@nguyenLisa
Copy link
Member Author

Referencing issue #26

@codecov-io
Copy link

codecov-io commented Nov 24, 2018

Codecov Report

Merging #30 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #30   +/-   ##
=====================================
  Coverage        0%    0%           
=====================================
  Files            9     9           
  Lines          194   200    +6     
  Branches         9     8    -1     
=====================================
- Misses         194   200    +6
Impacted Files Coverage Δ
...ain/scala/de/upb/cs/swt/delphi/cli/DelphiCLI.scala 0% <0%> (ø) ⬆️
...upb/cs/swt/delphi/cli/commands/SearchCommand.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655272a...fb14f37. Read the comment docs.

And refactoring to bring the search function to under 50 lines.
@delphi-hub delphi-hub deleted a comment Nov 24, 2018
@delphi-hub delphi-hub deleted a comment Nov 24, 2018
@delphi-hub delphi-hub deleted a comment Nov 24, 2018
@delphi-hub delphi-hub deleted a comment Nov 24, 2018
@delphi-hub delphi-hub deleted a comment Nov 24, 2018
@delphi-hub delphi-hub deleted a comment Nov 25, 2018
@nguyenLisa nguyenLisa requested a review from bhermann November 25, 2018 01:38
Copy link
Member

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏🏼

@bhermann bhermann merged commit 6ee305e into develop Nov 28, 2018
@bhermann bhermann deleted the search-timeout branch November 28, 2018 14:27
@ghost ghost removed the review label Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants