Deepcompile: Make size of activation to free configurable #7582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
With the increasing number of compile options, passing each option as a separate argument becomes tedious. Signed-off-by: Junjie Mao <[email protected]>
eternalNight
force-pushed
the
eternalNight/make_free_threshold_configurable
branch
from
39c49bb to
7038689
Compare
Signed-off-by: Junjie Mao <[email protected]>
eternalNight
force-pushed
the
eternalNight/make_free_threshold_configurable
branch
from
7038689 to
f9a6c1a
Compare
tohtana
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
@eternalNight Thank you for the improvement! Other config items are now easier to extend as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deepcompile free-activation mode, only activations larger than a threshold are eagerly freed. The threshold is hardcoded today and thus may not be suitable in all cases.
This PR first generalizes the dc.init() interface to take the whole compile_config object, and then converts the threshold into a config item.
This corresponds to issue 3 of #7577.