-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add LLMDocumentContentExtractor
to enable Vision-based LLMs to describe/convert an image into text
#338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 16006161725Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
LLMContentExtractor
to enable Vision-based LLMs to describe/convert an image into textLLMDocumentContentExtractor
to enable Vision-based LLMs to describe/convert an image into text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall design looks good.
I left two initial minor comments.
haystack_experimental/components/extractors/llm_document_content_extractor.py
Outdated
Show resolved
Hide resolved
haystack_experimental/components/extractors/llm_document_content_extractor.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few minor comments
haystack_experimental/components/extractors/llm_document_content_extractor.py
Show resolved
Hide resolved
haystack_experimental/components/extractors/llm_document_content_extractor.py
Outdated
Show resolved
Hide resolved
haystack_experimental/components/extractors/llm_document_content_extractor.py
Outdated
Show resolved
Hide resolved
haystack_experimental/components/extractors/llm_document_content_extractor.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Related Issues
DocumentCaptioner
: takes in Image Documents and returns same Documents with an image enhanced with text description haystack#9516Proposed Changes:
LLMDocumentContentExtractor
to enable Vision-based LLMs to describe/convert an image into text.Indexing Example
Sample output from Indexing Example
Indexing Pipeline Graph
Query Pipeline Graph
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.