Fix apply_chat_template for function calling (Issue #860) #877
+348
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the chat template to properly handle function calls by: 1. Using safe dictionary access with .get() 2. Converting function arguments to JSON with |tojson filter 3. Adding better empty content handling Fixes deepseek-ai#860
|
Please review . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix chat_template for Function Calling (Issue #860)
This PR fixes a bug in the tokenizer's chat template that caused errors when using apply_chat_template with function calling tools.
Description of changes
I've modified the chat template in tokenizer_config.json to:
Use safer dictionary access through .get() methods
Properly convert function arguments to JSON strings using the |tojson filter
Support empty content fields gracefully
Additional documentation
Added a demonstration script showing how to use function calling
Updated documentation on function calling capabilities
Related issues
Fixes #860