Skip to content

Introduce pre-commit hook and s3 backend parser to correct tf backend provider before submit #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

syscl
Copy link
Contributor

@syscl syscl commented Jul 15, 2025

This simplify the multi-tenant env management, as it uses to comment it back and forth, no longer needed this step just by:

terraform init -backend-config=backend-s3.conf
...

cursor[bot]

This comment was marked as outdated.

@syscl syscl changed the title Switch to use backend config s3 for multi-tenant env Switch to use backend config s3 for multi-tenant env + pre-commit hook Jul 16, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Go Version Specified in Setup Script

The scripts/setup-git-hooks.sh script and FAQ.md documentation incorrectly specify Go version 1.24.5 as required. This version does not exist, causing the setup script's Go version check to always fail and preventing git hook installation. This also creates user confusion, especially since the go.mod file indicates Go 1.21 is the actual requirement.

scripts/setup-git-hooks.sh#L15-L16

GO_VERSION=$(go version | grep -o 'go[0-9]\+\.[0-9]\+\.[0-9]\+' | sed 's/go//')
REQUIRED_VERSION="1.24.5"

FAQ.md#L178-L179

aws-setup/FAQ.md

Lines 178 to 179 in e732b57

**A**: Go 1.24.5 is required for the hclwrite-based backend management. Install with `brew install go` on macOS or from [golang.org](https://golang.org/dl/).

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@syscl syscl changed the title Switch to use backend config s3 for multi-tenant env + pre-commit hook Introduce pre-commit hook and s3 backend parser to correct tf backend provider before submit Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant