[chore]: Change reload approach to receive decofile as payload

[mcandeia]

Summary by CodeRabbit

• Bug Fixes
  • Improved reload endpoint request handling with enhanced error validation and clearer error messages for invalid requests.
  • Streamlined reload response format for better performance and reliability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The PR replaces a query-parameter-based polling mechanism in the reload endpoint with direct body-based decofile handling. The new implementation parses JSON from the request body, validates the decofile field, updates state.release directly, and returns a success confirmation instead of elapsed time metrics. Polling loops, file reads, and timeout logic are removed.

Changes

Cohort / File(s)	Change Summary
Reload handler refactoring runtime/routes/reload.ts	Replaced query-parameter polling flow with JSON body parsing; decofile now extracted from request body instead of polled from filesystem; validation added for missing/invalid JSON; response changed from elapsed time to {"success": true}; polling loop, file-read, and timeout handling removed

Sequence Diagram

sequenceDiagram
    actor Client
    participant Handler as reload Handler
    participant State as state.release
    participant Response

    Client->>Handler: POST body: {decofile: "..."}
    Handler->>Handler: Parse JSON from body
    
    alt JSON invalid
        Handler->>Response: 400 "Invalid JSON in request body"
        Response->>Client: Error
    else decofile missing
        Handler->>Response: 400 "Missing decofile in request body"
        Response->>Client: Error
    else Valid decofile
        Handler->>State: set(decofile)
        State-->>Handler: OK
        Handler->>Response: {"success": true}
        Response->>Client: 200 Success
    end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

• Specific areas requiring attention:
  • JSON parsing and validation logic correctness
  • Error handling edge cases (malformed JSON, missing decofile field)
  • Optional chaining on state.release.set?.() call and its side effects
  • Impact analysis of removing the polling mechanism on dependent systems or clients expecting the previous behavior
  • Verification that no state or resolved management logic depended on the removed timeout/polling behavior

Possibly related PRs

• [chore]: Improve reload to be long polling #995: Modifies the same reload handler with long-poll/backoff scheduling, creating a direct conflict with this PR's removal of polling logic.
• [chore]: Deterministic Reload #999: Adds tsFile-based polling loop to the reload handler, which directly contradicts this PR's simplification away from file polling.
• Implements decofile hotswap apis #993: Modifies state.release interactions in the reload handler for decofile hotswap behavior, relevant to the new direct state.release.set?.() call.

Poem

🐰 No more polling, no more wait,
JSON from the body, oh so great!
Simplified flow, direct and clean,
The fastest reload we've ever seen! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/post-payload

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51b8799 and feba2f7.

📒 Files selected for processing (1)

• runtime/routes/reload.ts (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Tagging Options

Should a new tag be published when this PR is merged?

• 👍 for Patch 1.129.3 update
• 🎉 for Minor 1.130.0 update
• 🚀 for Major 2.0.0 update