fix: add null check for component in awesome_map API fetcher #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Decidim environment I was testing, I encountered a case where the
resultfromapi.fetchAll()in theFetcher.fetch()function (decidim/decidim_awesome/awesome_map/api/fetcher.js) returned{"component": null}.In this case, accessing
result.component[this.collection]in fetcher.js throws an error.This PR adds a null check for
result.componentand callsonFinished()before returning early to prevent the error.