Skip to content

Conversation

@takahashim
Copy link
Contributor

In a Decidim environment I was testing, I encountered a case where the result from api.fetchAll() in the Fetcher.fetch() function (decidim/decidim_awesome/awesome_map/api/fetcher.js) returned {"component": null}.

In this case, accessing result.component[this.collection] in fetcher.js throws an error.

This PR adds a null check for result.component and calls onFinished() before returning early to prevent the error.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.75%. Comparing base (0119a5a) to head (9c76737).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   92.35%   96.75%   +4.39%     
==========================================
  Files         166      166              
  Lines        4250     4250              
==========================================
+ Hits         3925     4112     +187     
+ Misses        325      138     -187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@takahashim takahashim marked this pull request as ready for review December 15, 2025 17:38
Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@microstudi microstudi merged commit 81e18c1 into decidim-ice:main Dec 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants