Skip to content

Conversation

@davidbeig
Copy link
Contributor

As reported in #458 the check system page fails when the decidim-conferences module is not loaded in the application.

Since we have the hash of overriden files it was trying to load the module to check the md5 hash, but it failed since the module did not exist.

This change will only show the checks for the modules that have been loaded in the application. Maybe we want to change it so that it also shows modules that can be overriden by decidim-awesome but that are not inside the instance.

I would need some review on how to approach this @microstudi

@davidbeig davidbeig added the bug Something isn't working label Sep 29, 2025
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (b284f28) to head (8fda508).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         157      157           
  Lines        4075     4076    +1     
=======================================
+ Hits         3940     3941    +1     
  Misses        135      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative could be just use rescue? or use the built in Decidim.module_installed?

or the underlying class:

next unless Decidim::DependencyResolver.instance.needed?(package)

@davidbeig davidbeig requested a review from microstudi October 1, 2025 08:06
@microstudi microstudi merged commit daa6c0b into main Oct 14, 2025
16 of 17 checks passed
@microstudi microstudi deleted the fix/check_when_module_not_loaded branch October 14, 2025 08:14
@sdelcroix
Copy link
Contributor

Is it possible to backport it to the release/0.29-stable branch ? :)

microstudi pushed a commit that referenced this pull request Oct 17, 2025
* only show checks for loaded modules

* change check to use Decidim::DependencyResolver
@microstudi
Copy link
Contributor

Is it possible to backport it to the release/0.29-stable branch ? :)

Sure thing! done

@sdelcroix
Copy link
Contributor

@microstudi Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gem::MissingSpecError (Could not find 'decidim-conferences' after upgrade to 0.12.4 (Decidim 0.29)

4 participants