-
Notifications
You must be signed in to change notification settings - Fork 37
Fix check system when module not loaded #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 157 157
Lines 4075 4076 +1
=======================================
+ Hits 3940 3941 +1
Misses 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
microstudi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative could be just use rescue? or use the built in Decidim.module_installed?
or the underlying class:
next unless Decidim::DependencyResolver.instance.needed?(package)
|
Is it possible to backport it to the release/0.29-stable branch ? :) |
* only show checks for loaded modules * change check to use Decidim::DependencyResolver
Sure thing! done |
|
@microstudi Thank you very much ! |
As reported in #458 the check system page fails when the
decidim-conferencesmodule is not loaded in the application.Since we have the hash of overriden files it was trying to load the module to check the md5 hash, but it failed since the module did not exist.
This change will only show the checks for the modules that have been loaded in the application. Maybe we want to change it so that it also shows modules that can be overriden by
decidim-awesomebut that are not inside the instance.I would need some review on how to approach this @microstudi