Skip to content

Conversation

@davidbeig
Copy link
Contributor

In #427 we found that hashcash was not valid when login inside components. It turns out it didn't work in initiatives and conferences. Therefore we have added the needed concern to the Decidim::ApplicationController base controller.

@davidbeig davidbeig requested a review from microstudi July 31, 2025 16:09
@davidbeig davidbeig self-assigned this Jul 31, 2025
@davidbeig davidbeig added the bug Something isn't working label Jul 31, 2025
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.03%. Comparing base (1fcf371) to head (6c08e6e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         154      154           
  Lines        3986     3986           
=======================================
  Hits         3868     3868           
  Misses        118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@microstudi microstudi merged commit d4097d3 into main Aug 21, 2025
11 checks passed
@microstudi microstudi deleted the add_hashcash_to_all_controllers branch August 21, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants