Create custom styles for admin #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microstudi
requested changes
Oct 21, 2024
Contributor
microstudi
left a comment
microstudi
left a comment
There was a problem hiding this comment.
Good job.
To finish it, please check the comments, there are some inconsistencies in the constrains plural names.
On the other hand, the spec spec/system/admin/admin_manages_scoped_admin_styles_spec.rb is repeating a lot of code, from spec/system/admin/admin_manages_scoped_styles_spec.rb. Can you do the same as is done in spec/system/admin/admin_manages_proposal_custom_fields_spec.rb using shared examples?
And, finally, please update the screenshots and explanations from the README.md file. Probably editing the point 8 with two subsection 8.1 (public styles) and 8.2 (admin styles)
app/overrides/layouts/decidim/admin/_header/add_awesome_tags.html.erb.deface
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
===========================================
+ Coverage 68.85% 96.75% +27.90%
===========================================
Files 80 140 +60
Lines 2106 3574 +1468
===========================================
+ Hits 1450 3458 +2008
+ Misses 656 116 -540 ☔ View full report in Codecov by Sentry. |
microstudi
reviewed
Oct 29, 2024
app/overrides/layouts/decidim/admin/_header/add_awesome_tags.html.erb.deface
Outdated
Show resolved
Hide resolved
microstudi
reviewed
Oct 29, 2024
app/overrides/layouts/decidim/admin/_header/add_awesome_custom_styles.html.erb.deface
Outdated
Show resolved
Hide resolved
microstudi
added a commit
that referenced
this pull request
Oct 29, 2024
* divide custom_styles menu * refactor scoped_styles_controller * add scoped_admin_styles config_key * refactor commands * fix admin_manages_scoped_styles_spec * fix destroy_scoped_style_spec * apply custom_style in the admin * refactor form_scoped_styles * add scoped_admin_spec * fix key in plural * fix system specs * add custom_styles partial for admin * add trailing line * apply changes suggested * update readme * ignore unused keys * fix constraints_controller spec * fix admin spec * fix destroy_scoped_style_spec * fix awesome_summary_spec * fix user_uses_custom_time_zones_spec * create a new deface file * modify override method --------- Co-authored-by: Ivan Vergés <[email protected]>
microstudi
added a commit
that referenced
this pull request
Nov 6, 2024
* Create custom styles for admin (#337) * divide custom_styles menu * refactor scoped_styles_controller * add scoped_admin_styles config_key * refactor commands * fix admin_manages_scoped_styles_spec * fix destroy_scoped_style_spec * apply custom_style in the admin * refactor form_scoped_styles * add scoped_admin_spec * fix key in plural * fix system specs * add custom_styles partial for admin * add trailing line * apply changes suggested * update readme * ignore unused keys * fix constraints_controller spec * fix admin spec * fix destroy_scoped_style_spec * fix awesome_summary_spec * fix user_uses_custom_time_zones_spec * create a new deface file * modify override method --------- Co-authored-by: Ivan Vergés <[email protected]> * Add verification tweaks (#334) * add force verfication option * add text help. public logic * add specs * update awesome decidim ver * add specs * fix checksums * add pending verifications * add test cases * fix proposal private body edit * update text * restore gemfile * restores package.json * fix package.json * fix rubocop * fix summay specs * fix icons in menu and scoped styles views * fix javascript and erb * fix more specs * fix compact blank * fix scoped styles specs * fix scoped styles specs * fix verifications specs * fix 0.26 spec * fix 26 spec --------- Co-authored-by: Elvia Benedith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Create custom styles for admin. Divide the current custom styles menu in two parts, one for the public frontend and the other for the admin panel.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
menu
public frontend
admin panel