Skip to content

Conversation

@froger
Copy link
Contributor

@froger froger commented May 14, 2024

Include a new feature in the Awesome module: Add private fields to custom proposals.

As a participation designer, I can define private fields for proposals to ask proposers for personal information. This personal information could be required to submit a proposal and should not involve an extra step in the proposal submission process.

Context
The city of Lausanne wanted to request private fields for their Participatory Budgeting (PB) in order to:

  • Get consent for contacting proposers.
  • Obtain a phone number.
  • Collect additional information on the project (e.g., postal addresses to send materials).

Open Source Politics also contributes, financing adaptations for export and compatibility with version 0.27. <3

Solution

In the custom field administration, add another "custom field" zone, reserved for private fields.
In the form, add a section at the end for private fields.
Add an exporter, not exposed to open-data, to export personal data from the administration.
Change exporters of proposals to include custom fields.

Screenshots
Proposal form, user side
screencapture-theme-dev-voca-city-processes-nisi-non-f-14-proposals-45-edit-draft-2024-05-14-11_25_27

Confirm screen, without private data
Screenshot 2024-05-14 at 11 26 27

Published proposal, without private data
Screenshot 2024-05-14 at 11 26 39

Visualization of the fields, admin side
Screenshot 2024-05-14 at 11 34 47

Export options for private data
Screenshot 2024-05-14 at 11 31 22

Proposal administration
screencapture-theme-dev-voca-city-admin-decidim-awesome-config-proposal-custom-fields-2024-05-14-10_15_08

rsdeus and others added 25 commits March 2, 2023 12:14
* New translations en.yml (Czech)

* New translations en.yml (Czech)
* add admin config option in proposals

* add amendments controller concern

* limit amendments on controller

* limit only new and create methods

* add modal explanation window

* do not show modal if amendments limit disabled

* add test cases

* fx locales

* add readme

* fix locales

* remove quotes

* remove space

* New Crowdin updates (decidim-ice#264)

* New translations en.yml (Romanian)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Czech)

* New translations en.yml (German)

* New translations en.yml (Basque)

* New translations en.yml (Hungarian)

* New translations en.yml (Italian)

* New translations en.yml (Dutch)

* New translations en.yml (Swedish)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (French)

* New translations en.yml (French)

* New translations en.yml (Czech)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (Czech)

* New translations en.yml (German)

* New translations en.yml (Japanese)

* New translations en.yml (German)

* New translations en.yml (Romanian)

* New translations en.yml (Basque)

* New translations en.yml (Dutch)

* New translations en.yml (Swedish)

* New translations en.yml (Portuguese, Brazilian)

* New translations en.yml (Hungarian)

* New translations en.yml (German)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (German)

* New translations en.yml (French)

* New translations en.yml (Spanish)

* New translations en.yml (Catalan)

* New translations en.yml (German)

* New translations en.yml (French)

* New translations en.yml (Japanese)

* New translations en.yml (Czech)

* New translations en.yml (Japanese) (decidim-ice#269)

* skip hidden emendations

---------

Co-authored-by: PokeCode Bot <[email protected]>
* fix hidden images in public proposals

* fix offences

* fix 27 configuration

* fix overrides
@froger
Copy link
Contributor Author

froger commented May 14, 2024

So from the pipelines, I see I need to do at least:

  • Fix tests to have pipelines passing
  • Fix linting

@froger froger marked this pull request as draft June 6, 2024 09:54
@froger froger changed the base branch from main to develop June 6, 2024 09:54
@froger
Copy link
Contributor Author

froger commented Jun 6, 2024

Putting this PR in draft the time I make the necessary updates.

@simonaszilinskas
Copy link

Hey @froger , just wanted to ask if you had any news concerning the requested changes

@paarals
Copy link
Contributor

paarals commented Jun 24, 2024

Hey @froger , just wanted to ask if you had any news concerning the requested changes

also, this feature will may be cover with Roadmap (view).

@froger froger force-pushed the feat/awesome_decidim_private_fields branch 5 times, most recently from cdca347 to d607ac5 Compare June 27, 2024 20:39
@froger froger force-pushed the feat/awesome_decidim_private_fields branch from d607ac5 to e8663b2 Compare June 27, 2024 20:44
@froger
Copy link
Contributor Author

froger commented Jun 27, 2024

Hello all,

  • The administration looks now better, but still is without tabs. After discussing with Lucien, we will make a design proposal to refactor the administration of decidim awesome in a more sustainable way. (in another issue).
  • The private fields are now encrypted
  • The PR should looks a bit better, synced with develop branch
  • private fields are now a jsonb , that can handle translation (still don't know why we would translate private data)

We still miss:

  • pipelines that should pass
  • tests should pass, it seems some tests on collaboratives drafts are not passing, didn't checked this out yet.

@froger
Copy link
Contributor Author

froger commented Jun 27, 2024

Hey @froger , just wanted to ask if you had any news concerning the requested changes

also, this feature will may be cover with Roadmap (view).

Our customer needs where quiet specifics to having a "private section" of the form. I am unsure the feature you mention will attend their need, but we can discuss on this.

@microstudi
Copy link
Contributor

@froger if you are ok with it, we are going to finish this PR as we have time and certain pressure to finish it this month.

I'd like very much to maintain you as the author of the PR to recognize your good work. To do so, you should create this PR from a branch in this repository (I've invited you now), then we will be able to add commits to it in order to finish it.

On the other hand, we will make a new PR for the develop branch to add this feature to the 0.28 too.

@froger
Copy link
Contributor Author

froger commented Jul 8, 2024

closing in favor of #314
@microstudi as discussed, I've open a branch local to this repository. Feel free to update the code ;)
Thanks a lot for your help.

@froger froger closed this Jul 8, 2024
@microstudi
Copy link
Contributor

Thanks to you @froger , we'll finish this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants