Skip to content

Conversation

@ElviaBth
Copy link
Contributor

@ElviaBth ElviaBth commented Mar 14, 2024

🎩 What? Why?
Auto-save for surveys and forms.

📌 Related Issues
#/270 Upgrade 0.28 pending task 2.

📷 Screenshots
image
image

♥️ Thank you!

@codecov
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (a851688) to head (84a83af).
Report is 41 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #280      +/-   ##
===========================================
- Coverage    96.02%   93.46%   -2.56%     
===========================================
  Files           97      125      +28     
  Lines         2440     3521    +1081     
===========================================
+ Hits          2343     3291     +948     
- Misses          97      230     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElviaBth ElviaBth mentioned this pull request Mar 15, 2024
20 tasks
Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElviaBth this PR needs more things

On one hand, it is introducing changes related to the integram chat, this should not be here (see some comments).

On the other hand, this feature is about saving temporary data on forms using the localstorage browser capabilities. This is done with the script "autosave.js" (which uses https://github.com/appleple/form-storage in a npm package).

You need to:

  1. Upgrade the formstorage package (if possible) in package.json
  2. Adapt the autosave.js file so it removes jQuery dependencies
  3. Uncomment the import in the decidim_application.js file

Thanks!

@microstudi microstudi merged commit b347da5 into develop Mar 20, 2024
@microstudi microstudi deleted the feature/autosave_surveys_and_forms branch March 20, 2024 15:05
@microstudi microstudi mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants