Make sure the 'href' attribute of the base tag points to the web page's base.. #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web page's base. Some website specify the href of the base tag as '/'. This causes the JDOMParser to set: * dom.baseURI = 'chrome-extension://nghfdnngoejlhedogdpikdlkmdfoojii/' * dom.documentURI = 'chrome-extension://nghfdnngoejlhedogdpikdlkmdfoojii/_generated_background_page.html' when it parse HTML text in the background context and subsequently Readability.js genarates garbage for local links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #201 .
Some website specify the href of the base tag as '/' rather than the base uri of the website. This causes the JDOMParser to set:
when it parse HTML text in the background context.
As a consequence
Readability.jsgenerates garbage for local links.With this change https://steven-giesel.com/blogPost/79ce95ad-17a9-4537-8f1b-48d71efc585d reported by @nicolaiarocci works ok;