Resolve Obsidian Filename Determination Issue in background.js #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use formatTitle(article) instead of article.title in obsidian func
use formatTitle(article) instead of article.title in obsidian func
|
LGTM |
|
@deathau Is it convenient to merge? |
|
3.4.0 still doesn't work. Did you forget to build it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the Obsidian integration issue related to filename determination in the
background.jsfile. The problem was identified in the use ofarticle.title, which did not adhere to the "Template for title/filename" setting. The fix involves replacingarticle.titlewithawait formatTitle(article), ensuring proper alignment with user configuration preferences.Changes Made
background.js: replacedarticle.titlewithawait formatTitle(article).Issue Reference
Closes #289