Allow supervisord environment vars to have "="#572
Merged
ddollar merged 1 commit intoApr 23, 2016
Conversation
Prior to this PR, an environment variable configured for use with Foreman could not contain a `?`, `=` or `&` (common in URLs) if the target configuration was set to SupervisorD. This PR cleans up the output from `Shellwords.escape` in order to be ready for use in a `app*.conf` file. I've updated the tests to cover this particular issue. Fixes #571 Fixes #519 /cc @inbeom, @ddollar
Contributor
Author
|
In browsing through branches, I see this as another possible approach. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, an environment variable configured for use with Foreman could not contain a
?,=or&(common in URLs) if the target configuration was set to SupervisorD. This PR cleans up the output fromShellwords.escapein order to be ready for use in aapp*.conffile. I've updated the tests to cover this particular issue.From the documentation for Shellwords
From the documentation for SupervisorD
Fixes #571
Fixes #519
/cc @inbeom, @ddollar