Skip to content

detectSeries() bug fixes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

detectSeries() bug fixes #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7efbf72
detectSeries() iterator does not have to return a promise.
Jul 27, 2015
8f72b0a
_notFound passed through subsequent iterations of detectSeries()
Jul 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions async.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,11 @@ module.exports = async =

detectSeries: Q.promised (arr, iterator, _notFound=undefined) ->
return Q _notFound if arr.length is 0
iterator(arr[0]).then (ok) ->
Q(iterator(arr[0])).then (ok) ->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this

Q.try(iterator, arr[0]).then (ok) ->

that way if you have an exception it'll get caught properly at toplevel.

if ok
arr[0]
else
async.detectSeries arr[1..], iterator
async.detectSeries arr[1..], iterator, _notFound

# [a] -> (a -> P b) -> [a]
# basically a swartzian transform
Expand Down