Skip to content

#1119 Make sure tab updates are rendered correctly #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

FRosner
Copy link
Contributor

@FRosner FRosner commented Apr 15, 2025

Summary

This PR sets dashChildrenUpdate to true on the tabs component as advised by plotly/dash#3268 to address a regression introduced in Dash 3 that would prevent tabs from getting rendered properly after updating them via a callback.

References

Copy link
Collaborator

@tcbegley tcbegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this! Let me just have a think about whether there are other components where this change would be relevant and then I will merge.

@tcbegley
Copy link
Collaborator

We're all good, I was wondering if Accordion and AccordionItem might need a similar update, but they work differently to Tabs and Tab so we're all good.

@tcbegley tcbegley merged commit 8c1e456 into dbc-team:main Apr 15, 2025
8 checks passed
This was referenced Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab component being enabled via callback not applied correctly
2 participants