Load options form database.json instead of command line args

[mdreizin]

It would be nice to have ability to load any options from database.json or .db-migraterc instead of command line args.

Example:

{
  "migrations-dir": "./src/migrations",
  "migration-table": "migration"
}

[wzrdtales]

All options from the CLI are also available from the config see https://github.com/db-migrate/node-db-migrate#configuration

Or do I misunderstand your problem?

[mdreizin]

@wzrdtales

Currently db-migrate doesn't respect migrations-dir, migration-table options from config file.

Only supported property is sql-file under 0.9.x version:

{
    "sql-file" : true
}

It would be nice if db-migrate can use options from config file if command line doesn't contain them.

{
  "dev": {
    "driver": "pg",
    "host": "localhost",
    "database": "test"
  },
  "migrations-dir": "./src/migrations",
  "migration-table": "migration"
}

or

{
  "dev": {
    "driver": "pg",
    "host": "localhost",
    "database": "test"
  },
  "migration": {
    "dir": "./src/migrations",
    "table": "migration"
  }
}

As I can see this behaviour is not supported now. Please see node-db-migrate/v0.9.x/bin/db-migrate:139.

[wzrdtales]

duh! You're right, my fault. Actually this is something I have planned and wanted to do together while replacing optimist. I have moved that plans to a later point as there are other things that I'm working on currently. E.g. making the framework zero downtime friendly and other stuff, but I definitely look out to accomplish this. I also watched out for other modules that can replace optimist and probably I will go for commander.

PRs are welcome though :)

[wzrdtales]

refers to #224

[wzrdtales]

We're going to extend the defaults object with the current config for a quick fix for this issue.

[troygoode]

The "sql-file" option is not loaded from database.json if the DATABASE_URL env var is used.

[wzrdtales]

@troygoode Mh, yeah in the current constellation this an either or and not layered. And I don't consider this as a bug as of now.

DATABASE_URL is something that is only really useful to production environments, that are configured through environment configs. E.g. Docker, Heroku, ...
But it is nothing that you would use in development, and the same goes for the sql-file option. You don't need it in production, so the DATABASE_URL does not need any possibility to define it. While you can define it, just take a look at typical DATABASE_URL specs. E.g. on the mongodb docs https://docs.mongodb.com/manual/reference/connection-string/#standard-connection-string-format

Anyhow, I still don't consider this as a bug yet, unless you can show me a use case where it makes sense to have layered configurations instead.

[wzrdtales]

Also to note, you should open a new issue. Your request has nothing to do with this issue, this one is about CLI and having a rc style config, which is also something that is being introduced soon though.