soft-reboot doesn't execute shutdown hooks

[davmac314]

soft-reboot doesn't execute the shutdown hook script, which isn't documented. It should at least be documented, or otherwise fixed.

(Probably want to execute them by executing shutdown with some arguments such as -s --system, but will need to fork to run shutdown rather than execing it without forking).

[mobin-2008]

Another idea can be execing shutdown-hook. This makes soft-reboot much more flexible and users can implement their own solution for soft-reboot such as a root switch mechanism:

#!/bin/sh

if [ "$1" = "soft-reboot" ]; then
    if mountpoint /new_root >/dev/null 2>&1; then
        mount --bind /proc /new_root/proc
        mount --bind /run /new_root/run
        mount --bind /dev /new_root/dev
        exec chroot /new_root dinit
    fi
    exec dinit
fi

... # Other commands

even we can pass current dinit arguments as $2 next arguments and with that users can filter out anything they want or add anything they want.
@davmac314 WDYT?

[davmac314]

Another idea can be execing shutdown-hook

(I assume you mean from dinit, without first fork()ing)

@davmac314 WDYT?

I don't like the hook having different arguments depending on the shutdown type nor of the breaking change that this entails. I'm also not keen on having the script be responsible, for one type of shutdown but not the others, in actually completing the shutdown action.

I would prefer to keep the responsibility for executing shutdown hooks completely within shutdown.