Add OSVersion check and bail #169 #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OSVersion Check and Bail.
athegist
requested changes
Nov 11, 2017
| @@ -51,6 +51,11 @@ function GetTimestampUTC { | |||
| Get-Date (Get-Date).ToUniversalTime() -Format "yyyy-MM-ddTHH:mm:ssZ" | |||
| } | |||
|
|
|||
| if($((Get-WmiObject Win32_OperatingSystem).Name).Contains(" XP ")){ | |||
| Write-Error ("{0}: This script is not supported on Windows XP." -f (GetTimestampUTC)) | |||
There was a problem hiding this comment.
This may not work as expected for all localized versions of Windows. Also, XP and 2K3 are the same major.minor version number, but this check only looks for XP. Better to go by the major.minor version number returned by (Get-CimInstance Win32_OperatingSystem).Version and make sure that value is greater than 5.2. From memory, I can't recall if Get-CimInstance works on all windows OS versions, need to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OSVersion Check and Bail.