Remove the of statements

[roccomuso]

We might consider the idea to switch from a for (w of st.keys()) statement to a more common one Object.keys(st.keys())... right now webpack's uglify doesn't support the of keyword.

If we change this loop syntax with an older one, anyone can build and use the module also on the browser.

[davedoesdev]

In 2018 I'd like to write ES6 :)

https://github.com/webpack-contrib/uglifyjs-webpack-plugin says:

This plugin uses UglifyJS v3 (uglify-es) to minify your JavaScript

webpack =< v3.0.0 currently contains v0.4.6 of this plugin under webpack.optimize.UglifyJsPlugin as an alias. For usage of the latest version (v1.0.0), please follow the instructions below. Aliasing v1.0.0 as webpack.optimize.UglifyJsPlugin is scheduled for webpack v4.0.0

It looks like you can work around it in webpack.config.js, until webpack 4.0.0 arrives.

[roccomuso]

Sadly with the current create-react-app module you can't touch the webpack.config.js

[davedoesdev]

I think maybe the webpack.config.js is fine: https://github.com/facebook/create-react-app/blob/25184c4e91ebabd16fe1cde3d8630830e4a36a01/packages/react-scripts/config/webpack.config.prod.js#L385

But I can't see where it depends on uglifyjs-webpack-plugin.

[davedoesdev]

Ah, here: https://github.com/facebook/create-react-app/blob/3767d91886823349ec46288d9b7ea48d4149890a/packages/react-scripts/package.json#L60

which is version 1.1.6 so should be fine

[davedoesdev]

Looks like the fix came in here 15 days ago: facebook/create-react-app@ff54494

[davedoesdev]

facebook/create-react-app#3618

[davedoesdev]

@roccomuso did the latest create-react-app work?

[roccomuso]

@davedoesdev yes, thanks :)