feat:support gateway kernel client #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
echarles
reviewed
Jun 25, 2025
|
Change sounds reasonable to me (have proposed to add a space for better linting). Could you edit the first comment of this PR with a bit more context on the issue faced with gateway kernel client. Thx! |
lint Co-authored-by: Eric Charles <[email protected]>
echarles
reviewed
Jun 25, 2025
|
Thx. One more suggestion and we are good to go. |
lint Co-authored-by: Eric Charles <[email protected]>
echarles
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gateway Kernel Client does not currently implement the execute_interactive method. To support the nbmodel functionality when using a Gateway, the Gateway Kernel Client needs to provide this method. I have submitted a PR to the jupyter-server repository to add this support: jupyter-server/jupyter_server#1535.
Additionally, in the Gateway client, the header["date"] field in channel messages is a string (related code). Therefore, the _stdin_hook should be updated to handle this format accordingly.