-
Notifications
You must be signed in to change notification settings - Fork 88
Import ABC from collections.abc for Python 3.10 compatibility #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kabilar. 👍 Could you just update the changelog/releaselog and the version?
Also, didn't check but would you verify if the collections import is used across all files and apply this there too? I can verify once I am near my machine too.
Supersedes #1002 |
Thanks @kabilar. Just checked and looks like we'll need to update the usage of
Could you also update the |
Thanks @guzman-raphael! Good catch. I have incorporated your suggestions above. I did not update the import in |
And in |
Should we incorporate something like this to retain backwards compatibility? import collections
try:
collectionsAbc = collections.abc
except AttributeError:
collectionsAbc = collections |
@CBroz1 No, we don't need to be compatible to Python 2.7 because we never supported it. The current change is already compatible with all supporting versions of Python 3.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there was some confusion on my part and realized now that defaultdict
is actually available at collections
top-level. We can actually revert this then. Sorry about that.
Co-authored-by: Raphael Guzman <[email protected]>
Co-authored-by: Raphael Guzman <[email protected]>
Co-authored-by: Raphael Guzman <[email protected]>
Thanks @guzman-raphael. I have updated this pull request. |
Fix #1015. Since there was an issue with the certs in pull request #1002, I have opened this pull request. If there is a better strategy, feel free to close this pull request. Thanks!