fix(build): Add --copies flag to Python venv creation for better compatibility #14120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the --copies flag to the Python virtual environment creation command in the metadata-ingestion build.gradle file.
What changed:
- Modified the environmentSetup task to use python -m venv --copies ${venv_name} instead of python -m venv ${venv_name}
Why this matters:
The --copies flag ensures that Python files are copied into the virtual environment rather than symlinked. This can resolve issues with:
- File system compatibility (especially on Windows or network drives)
- Container environments where symlinks might not work correctly
- Build reproducibility across different environments
- Scenarios where the python executable is immutable (Nix environments)
This is a low-risk change that improves compatibility without affecting functionality.
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
|
anshbansal
previously requested changes
Jul 17, 2025
There was a problem hiding this comment.
@pedro93 This can cause an issue where if you are doing local development then you have to re-run the environment setup every time. This will cause local dev to be painful. Please make this an optional argument
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
--copiesflag to the Python virtual environment creation command in the metadata-ingestion build.gradle file.What changed:
environmentSetuptask to usepython -m venv --copies ${venv_name}instead ofpython -m venv ${venv_name}Why this matters:
The
--copiesflag ensures that Python files are copied into the virtual environment rather than symlinked. This can resolve issues with:This is a low-risk change that improves compatibility without affecting functionality.