-
Notifications
You must be signed in to change notification settings - Fork 52
docs: clarify input arrays in device placement #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change seems reasonable to me, it's more of a clarification than anything else. This numbered list was written with creation functions in mind I believe. The Before merging this, let's ensure the discussions in data-apis/array-api-compat#293 (and perhaps other places) have been settled to ensure it's all consistent. |
Co-authored-by: Lucy Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on linked discussions and workgroup discussion, the proposed rule changes have agreement. As such, I'll go ahead and merge. |
Clarify how input arrays should be considered for device placement.
This new line is a repetition of bullet point 2, three lines above:
However, I am observing very high levels of ambiguity among the community on the interpretation of this paragraph, where I've had multiple people insist that the device set in the context manager or global default device should trump the device of input arrays. At which point, since all real-life backends always have a global default device, input-to-output device propagation would fly out of the window.