check_process_leak overhaul #5739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
process_leak_kill
branch
from
22356e7 to
5fee49c
Compare
|
All test failures are unrelated |
gjoseph92
approved these changes
Feb 3, 2022
| """Wait until timeout for mp_context.active_children() to terminate. | ||
| Return list of active subprocesses after the timeout expired. | ||
| """ | ||
| t0 = time() |
There was a problem hiding this comment.
Tiny super nit: monotonic (or perhaps perf_counter) would technically be more appropriate here I think. I'm sure it will never ever make a difference in this case, and there are plenty of other more important places where we already use non-monotonic time and shouldn't. I'd just like to start being more careful about it.
There was a problem hiding this comment.
Something for a broader discussion maybe? If we want to switch to monotonic, it should be done consistently everywhere, e.g. replace metrics.time. As usual, Windows is a source of pain so need to thread carefully there.
Co-authored-by: Gabe Joseph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests in xarray decorated with
@gen_cluster(client=True), therefore not spawning any processes, are very flaky as they fail systematically oncheck_process_leak. I think the problem is caused by unrelated subprocesses, spawned by previous tests, that don't respond do SIGTERM.xref: pydata/xarray#6211
log: https://github.com/pydata/xarray/runs/4990065672