Skip to content

updates to be forward compatible with changes to package:shelf_web_socket #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 24.2.1-wip

- Update to be forward compatible with changes to `package:shelf_web_socket`.

## 24.2.0

- Consolidate `FrontendServerDdcStrategyProvider` and `FrontendServerRequireStrategyProvider` under a shared parent class. - [#2517](https://github.com/dart-lang/webdev/issues/2517)
Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/handlers/socket_connections.dart
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class WebSocketSocketHandler extends SocketHandler {

WebSocketSocketHandler() {
_handler = webSocketHandler(
(WebSocketChannel channel) =>
(WebSocketChannel channel, _) =>
_connectionsStream.add(WebSocketConnection(channel)),
);
}
Expand Down
4 changes: 2 additions & 2 deletions dwds/lib/src/services/debug_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ int _clientsConnected = 0;

Logger _logger = Logger('DebugService');

void Function(WebSocketChannel) _createNewConnectionHandler(
void Function(WebSocketChannel, String?) _createNewConnectionHandler(
ChromeProxyService chromeProxyService,
ServiceExtensionRegistry serviceExtensionRegistry, {
void Function(Map<String, Object>)? onRequest,
void Function(Map<String, Object?>)? onResponse,
}) {
return (webSocket) {
return (webSocket, subprotocol) {
final responseController = StreamController<Map<String, Object?>>();
webSocket.sink.addStream(
responseController.stream.map((response) {
Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/version.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dwds/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: dwds
# Every time this changes you need to run `dart run build_runner build`.
version: 24.2.0
version: 24.2.1-wip
description: >-
A service that proxies between the Chrome debug protocol and the Dart VM
service protocol.
Expand Down
2 changes: 1 addition & 1 deletion dwds/test/build/ensure_version_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ void main() {
expect(
Version.parse(packageVersion),
pubspec.version,
reason: 'Please run `pub run build_runner build '
reason: 'Please run `dart run build_runner build '
'--build-filter=lib/src/version.dart` to update the version.',
);
});
Expand Down
Loading