Skip to content

Wrap VM service API methods in an error handler to convert any exceptions into type RPCError #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 16, 2023
Merged

Wrap VM service API methods in an error handler to convert any exceptions into type RPCError #2144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e3f9f0a
Use new error codes from package:vm_service
elliette Jun 12, 2023
b0f5322
Wrap vm service API methods in error handlers
elliette Jun 13, 2023
7ec9989
Merge branch 'master' into issue-2140-2
elliette Jun 13, 2023
35cc357
Update CHANGELOG
elliette Jun 13, 2023
88dd43e
Fix analyzer errors
elliette Jun 13, 2023
78229ea
Update utility and add test
elliette Jun 14, 2023
72808f2
Format
elliette Jun 14, 2023
3fa9286
Rethrow SentinelExceptions as well
elliette Jun 14, 2023
41da5cb
Respond to PR comments
elliette Jun 14, 2023
259330c
Respond to more PR comments
elliette Jun 15, 2023
7b06c34
Trailing comma'
elliette Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
- Display type objects concisely. - [#2103](https://github.com/dart-lang/webdev/pull/2103)
- Support using scope in `ChromeProxyService.evaluateInFrame`. - [#2122](https://github.com/dart-lang/webdev/pull/2122)
- Check for new events more often in batched stream. - [#2123](https://github.com/dart-lang/webdev/pull/2123)
- Map Chrome error on `resume` to the same error returned by the Dart VM. - [#2133](https://github.com/dart-lang/webdev/issues/2133)
- Map Chrome error on `resume` to the same error returned by the Dart VM. - [#2133](https://github.com/dart-lang/webdev/issues/2133)
- VM service API methods throw type `RPCError`, same as the Dart VM. - [#2144](https://github.com/dart-lang/webdev/pull/2144)

## 19.0.0

Expand Down
Loading