[MV3 Debug Extension] Handle unexpected extension debugger disconnection events without crashing app #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
reviewed
Mar 7, 2023
| } | ||
| } | ||
|
|
||
| /// Starts a [DebugService] for Dart Debug Extension. | ||
| Future<void> _startExtensionDebugService() async { | ||
| Future<void> _startExtensionDebugService( | ||
| ExtensionDebugger extensionDebugger) async { | ||
| final extensionDebugger = await _extensionBackend!.extensionDebugger; |
There was a problem hiding this comment.
Should we use the extensionDebugger passed to the function instead?
There was a problem hiding this comment.
Oops yes! That was the whole point of passing in the param...
annagrin
reviewed
Mar 7, 2023
annagrin
reviewed
Mar 7, 2023
annagrin
approved these changes
Mar 8, 2023
Sure! Opened #2023 to track |
elliette
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/271611587
Before this PR, you could cause an app to crash by:
Depending on the timing, it might crash with an error thrown by DDS:
Or with an error thrown by package:sse:
This handles both cases by catching those errors, logging what went wrong, and closing the extension debugger.