Update builder logic for the Dart Debug Extension #1717
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| build/ | ||
| extension_key.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Copyright 2022 The Chromium Authors. All rights reserved. | ||
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
|
|
||
| # INSTRUCTIONS: | ||
|
|
||
| # Building DDC-compiled app (for development work): | ||
| # ./tool/build_extension.sh | ||
|
|
||
| # Building dart2js-compiled app (for release): | ||
| # ./tool/build_extension.sh prod | ||
|
|
||
| prod="false" | ||
|
|
||
| case "$1" in | ||
| prod) | ||
| prod="true" | ||
| shift;; | ||
| esac | ||
|
|
||
| # Clean existing build directory to avoid merge conflicts. | ||
| dart run build_runner clean | ||
|
|
||
| if [ $prod == true ]; then | ||
| echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
| echo "Building dart2js-compiled extension to build/web_prod directory." | ||
| echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
| dart run build_runner build web -o build -r | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
| echo "Building DDC-compiled extension to build/web directory." | ||
| echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
| dart run build_runner build web -o build | ||
| echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
| echo "Updating the manifest.json file in build/web directory." | ||
| echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
| dart tool/update_dev_manifest.dart | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'dart:io'; | ||
|
|
||
| /// Adds the extension key and updates the icon in the manifest.json. | ||
| void main() async { | ||
| final manifestJson = File('build/web/manifest.json'); | ||
| final extensionKey = File('extension_key.txt'); | ||
| final keyValue = | ||
| await extensionKey.exists() ? await extensionKey.readAsString() : null; | ||
| _updateManifest(manifestJson, extensionKey: keyValue); | ||
| } | ||
|
|
||
| Future<void> _updateManifest(File manifestJson, {String? extensionKey}) async { | ||
| final lines = manifestJson.readAsLinesSync(); | ||
| final newLines = <String>[]; | ||
| for (final line in lines) { | ||
| final trimmedLine = line.trimLeft(); | ||
| if (trimmedLine.startsWith('"name":') && extensionKey != null) { | ||
| newLines.add(line); | ||
| newLines.add('${line.leftPadding()}"key": "$extensionKey",'); | ||
| } else if (trimmedLine.startsWith('"default_icon":')) { | ||
| newLines.add('${line.leftPadding()}"default_icon": "dart_dev.png"'); | ||
| } else { | ||
| newLines.add(line); | ||
| } | ||
| } | ||
| final content = newLines.joinWithNewLine(); | ||
| return manifestJson.writeAsStringSync(content); | ||
| } | ||
|
|
||
| extension LeftPaddingExtension on String { | ||
| String leftPadding() { | ||
| String padding = ''; | ||
| int idx = 0; | ||
| while (idx < length && this[idx] == ' ') { | ||
| padding += ' '; | ||
| idx++; | ||
| } | ||
| return padding; | ||
| } | ||
| } | ||
|
|
||
| extension JoinExtension on List<String> { | ||
| String joinWithNewLine() { | ||
| return '${join('\n')}\n'; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How often did you find this was necessary? We don't expect a clean to be necessary for every build in typical workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, solved the problem with
--delete-conflicting-outputsflag. Was trying to prevent the prompt about conflicts from showing up when running the continuous integration tests