Fix DDC compilation error for the Dart Debug Extension #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
May 3, 2022
| attachDebuggerToTab(tabs[0]); | ||
| queryTabs(getCurrentTabQuery, allowInterop((List tabs) { | ||
| final tabList = List<Tab>.from(tabs); | ||
| if (tabList != null && tabList.isNotEmpty) { |
There was a problem hiding this comment.
tabList will never be null here
| if (tabs != null && tabs.isNotEmpty) { | ||
| attachDebuggerToTab(tabs[0]); | ||
| queryTabs(getCurrentTabQuery, allowInterop((List tabs) { | ||
| final tabList = List<Tab>.from(tabs); |
There was a problem hiding this comment.
we only ever us the first tab, do we need to create the full list for multiple tabs?
if (tabs.isNotEmpty) {
attachDebuggerToTab(tabList.first as Tab);
}There was a problem hiding this comment.
Good idea, done!
Also discovered a few other type errors when compiled with DDC, so I've fixed those as well.
natebosch
approved these changes
May 4, 2022
| @@ -363,7 +364,8 @@ void _forwardMessageToExternalExtensions( | |||
| } | |||
|
|
|||
| void _notifyPanelScriptOfChanges(List<DevToolsPanel> panels) { | |||
There was a problem hiding this comment.
Suggested change
| void _notifyPanelScriptOfChanges(List<DevToolsPanel> panels) { | |
| void _notifyPanelScriptOfChanges(List panels) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1506
Explicitly casts our tab list (which the compiler thought was
List<dynamic>) toList<Tab>.This is a known limitation of the Dart JS package (https://github.com/dart-lang/sdk/tree/master/pkg/js#list-instances-coming-from-javascript-will-always-be-listdynamic).