Skip to content

Don't fetch range if the object has no length #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

elliette
Copy link
Contributor

If a client sets the optional parameters offset / count in getObject, but the object they are requesting has no length, then DWDS should ignore those parameters.

Fixes #1439

@google-cla google-cla bot added the cla: yes label Nov 23, 2021
@elliette elliette requested a review from annagrin November 24, 2021 20:15
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the description of the fix to dwds/CHANGELOG.md?

Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 6184a08 into dart-lang:master Dec 1, 2021
@elliette elliette deleted the issue-1439-v2 branch December 24, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DWDS should ignore optional offset/count parameters in getObject request if the object has no length
2 participants