Skip to content

ChromeProxyService implements noSuchMethod #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2021
Merged

ChromeProxyService implements noSuchMethod #1448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0750d1
Override noSuchMethod in DWDS
elliette Nov 15, 2021
c848e3f
Resolve merge conflict
elliette Nov 15, 2021
9bce4e9
Format comment
elliette Nov 15, 2021
3158ea3
Unpin vmservice
elliette Nov 16, 2021
58fac2a
Change version
elliette Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dwds/lib/src/services/chrome_proxy_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,6 +1049,13 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
// TODO(https://github.com/dart-lang/webdev/issues/1446): implement.
throw UnimplementedError();
}

/// Prevent DWDS from blocking Dart SDK rolls if changes in package:vm_service
/// are unimplemented in DWDS.
@override
dynamic noSuchMethod(Invocation invocation) {
return super.noSuchMethod(invocation);
}
}

/// The `type`s of [ConsoleAPIEvent]s that are treated as `stderr` logs.
Expand Down
3 changes: 1 addition & 2 deletions dwds/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ dependencies:
stack_trace: ^1.10.0
sse: ^4.1.0
uuid: '>=2.0.0 <4.0.0'
# We pin the version because we implement the interface.
vm_service: 7.4.0
vm_service: ^7.4.0
web_socket_channel: ^2.0.0
webkit_inspection_protocol: ^1.0.0

Expand Down