Fix duplicated scripts and prep to publish dwds #1414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make inspector initializer wait on the same future as getScripts call in ChromeProxyService to make sure we populate caches only once. Prep to publish to support file picker work in devtools. Closes: dart-lang#1413
Contributor
|
I'm trying to see how this would be different but I don't see when the cache is ever populated. How does that happen? |
grouma
approved these changes
Sep 23, 2021
Contributor
Author
The cache is populated on first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make inspector initializer wait on the same future as
getScripts call in ChromeProxyService to make sure
we populate caches only once.
Prep to publish to support file picker work in devtools.
Closes: #1413