-
Notifications
You must be signed in to change notification settings - Fork 76
[benchmark_harness] require Dart 3.10, format code, prepare release #2256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kevmoo
commented
Nov 25, 2025
- [benchmark_harness] require Dart 3.10, format, prepare release
- tiny tweaks to readme
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares the benchmark_harness package for a new release. The changes correctly update the version in pubspec.yaml and CHANGELOG.md, and increase the required Dart SDK version to ^3.10.0. The codebase has also been formatted, which improves readability and consistency.
I have one piece of feedback regarding a documentation change in the README.md file, where the example output was updated but is now inconsistent with the actual output produced by the code. Otherwise, the changes look solid and ready for release.
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with
Coverage
|
| File | Coverage |
|---|---|
| pkgs/benchmark_harness/lib/src/async_benchmark_base.dart | 💚 87 % |
| pkgs/benchmark_harness/lib/src/bench_command/bench_options.dart | 💚 96 % ⬆️ 0 % |
| pkgs/benchmark_harness/lib/src/bench_command/compile_and_run.dart | 💚 91 % ⬆️ 0 % |
| pkgs/benchmark_harness/lib/src/measurement.dart | 💚 91 % ⬆️ 0 % |
| pkgs/benchmark_harness/lib/src/perf_benchmark_base.dart | 💔 Not covered |
| pkgs/benchmark_harness/lib/src/score_emitter.dart | 💚 17 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.