Avoid duplicated search box IDs #5319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 4aec2a8): https://dart-dev--pr5319-fix-5295-8x6otdwc.web.app (expires Sun, 12 Nov 2023 01:22:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
atsansone
approved these changes
Nov 7, 2023
MaryaBelanger
pushed a commit
that referenced
this pull request
Nov 14, 2023
The `name` field on an input is used for submitting the search, so it's okay for the IDs to be different, but the names to remain the same. Fixes #5295
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Jan 26, 2024
The `name` field on an input is used for submitting the search, so it's okay for the IDs to be different, but the names to remain the same. Fixes dart-lang#5295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
namefield on an input is used for submitting the search, so it's okay for the IDs to be different, but the names to remain the same.Fixes #5295