-
Notifications
You must be signed in to change notification settings - Fork 728
Update text colors and highlighting for increased contrast #5318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Visit the preview URL for this PR (updated for commit 3f220cb): https://dart-dev--pr5318-fix-increased-text-c-pjimk9oc.web.app (expires Tue, 14 Nov 2023 17:39:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to match the Dart design guidelines for color.
@atsansone These colors all come from the branding guidelines. I've gone ahead and updated a few others to match. Can we land this for the contrast fixes and any further branding alignment can happen as follow up? |
Updated colors to match Dart branding where needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Also updates various colors to more closely align with Dart/Flutter brand guidelines. Fixes #5293 --------- Co-authored-by: Anthony Sansone <[email protected]>
…#5318) Also updates various colors to more closely align with Dart/Flutter brand guidelines. Fixes dart-lang#5293 --------- Co-authored-by: Anthony Sansone <[email protected]>
Also updates various colors to more closely align with Dart/Flutter brand guidelines.
Fixes #5293