Skip to content

Conversation

parlough
Copy link
Member

@parlough parlough commented Nov 5, 2023

Also updates various colors to more closely align with Dart/Flutter brand guidelines.

Fixes #5293

Copy link

github-actions bot commented Nov 5, 2023

Visit the preview URL for this PR (updated for commit 3f220cb):

https://dart-dev--pr5318-fix-increased-text-c-pjimk9oc.web.app

(expires Tue, 14 Nov 2023 17:39:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to match the Dart design guidelines for color.

@parlough
Copy link
Member Author

parlough commented Nov 7, 2023

@atsansone These colors all come from the branding guidelines. I've gone ahead and updated a few others to match.

Can we land this for the contrast fixes and any further branding alignment can happen as follow up?

Updated colors to match Dart branding where needed.
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@atsansone atsansone assigned parlough and unassigned atsansone Nov 7, 2023
@parlough parlough merged commit b40c41c into main Nov 7, 2023
@parlough parlough deleted the fix/increased-text-contrast branch November 7, 2023 18:15
@parlough parlough removed the st.RFM label Nov 7, 2023
MaryaBelanger pushed a commit that referenced this pull request Nov 14, 2023
Also updates various colors to more closely align with Dart/Flutter
brand guidelines.

Fixes #5293

---------

Co-authored-by: Anthony Sansone <[email protected]>
atsansone added a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
…#5318)

Also updates various colors to more closely align with Dart/Flutter
brand guidelines.

Fixes dart-lang#5293

---------

Co-authored-by: Anthony Sansone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change base colors to improve contrast
2 participants