List.removeLast() docs error occurs if empty

[camsteffen]

Seems like this should be explicitly stated in the docs. I did not indicate the specific type of error because of #26087.

[lrhn]

Thanks for the suggestion. I'll probably phrase it differently, but it should be said somehow.

[mraleph]

@lrhn any ideas about alternative wording? Should this PR be closed if suggested wording does not satisfy your requirements?

[ulidtko]

I'd also like to see it documented which error exactly will happen. But, since #26087 is closed-not-planned (which means WONTFIX I guess), the error will indeed be of varying type.

I'd merge this PR easily as-is; for an extra mile of effort, I'd improve it further:

• If the list is empty, this method throws an exception (of unspecified type, see GitHub List.removeLast() throws an inconsistent error #26087).

[lrhn]

Just say:

 * The list must not be empty.

This is how we generally document prerequisites in the platform libraries. (We didn't always, which is why some documentation is not consistent, but this is the current official recommended approach.)

If a "must" requirement is not satisfied, the implementation will likely throw an Error, but there are situations where the throwing is best-effort only (mainly concurrent modification). We do allow JavaScript compiled code to rely on the underlying JavaScript throwing, so we don't want to enforce a specific Dart error to throw.

[lrhn]

Than you for the PR. I agree that it's a good idea to document the requirement.
We have a standard way of writing such prerequisites in platform library docs, so I have suggested that wording.

[lrhn]

Than you for the PR. I agree that it's a good idea to document the requirement.
We have a standard way of writing such prerequisites in platform library docs, so I have suggested that wording.

[camsteffen]

I changed the wording as suggested.

[mit-mit]

Signoff in https://dart-review.googlesource.com/c/sdk/+/107822