Incomplete sentence `argument_must_be_a_constant`

[MaryaBelanger]

sdk/pkg/analyzer/messages.yaml

Line 18184 in c2301ae

The analyzer also produces this diagnostic when the value of the

I think the rest of this sentence got cut off:

The analyzer also produces this diagnostic when the value of the
exceptionalReturn argument of Pointer.fromFunction or
NativeCallable.isolateLocal.

"...when the value of ... or ..." when those values do what?

[bwilkerson]

@dcharkes

[dcharkes]

I'm unsure what this is referring to. The file linked has the rest of the sentence on the next line?

[MaryaBelanger]

@dcharkes referring to the entire paragraph on lines 18184-18186

It says "The analyzer also produces this diagnostic when the value of the x argument of y or z." But it doesn't complete the sentence and tell me what the condition is, it just says "when the argument..." When the argument is/does what?

For example, the paragraph right before it says:

The analyzer produces this diagnostic when an invocation of either
Pointer.asFunction or DynamicLibrary.lookupFunction has an isLeaf
argument whose value isn't a constant expression.

Is it the same condition? I.e. should line 18186 be followed by has an isLeafargument whose value isn't a constant expression.?

The analyzer also produces this diagnostic when the value of the
exceptionalReturn argument of Pointer.fromFunction or
NativeCallable.isolateLocal has an isLeafargument
whose value isn't a constant expression.?

(This was updated ~3 months ago, but even before that the sentence was incomplete. Maybe @liamappelbe (last commit in the blame) has the answer?)

[dcharkes]

Gotcha: This should be:

      The analyzer produces this diagnostic when an invocation of either
      `Pointer.asFunction` or `DynamicLibrary.lookupFunction` has an `isLeaf`
      argument whose value isn't a constant expression.

      The analyzer also produces this diagnostic when an invocation of either
      `Pointer.fromFunction` or `NativeCallable.isolateLocal` has an
      `exceptionalReturn` argument whose value isn't a constant expression.

I'll make a CL.

[MaryaBelanger]

Thank you!