Warn if the user did not specify a language on the fenced code block #2559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
force-pushed
the
misc/warn-on-no-language
branch
from
5ea9e62 to
cc04427
Compare
jcollins-g
suggested changes
Mar 8, 2021
|
As a note, I will follow up on the SDK repo with fixes for the few warnings this currently produces there. |
jcollins-g
approved these changes
Mar 9, 2021
This was referenced Mar 10, 2021
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 10, 2021
A warning to catch these situations was added in dart-lang/dartdoc#2559 so this adds tags to the code blocks in the SDK which were missing them as caught by the new warning. Change-Id: Iaadbb6e1b811ecac3b95a6c6f64cb689d2eb2d26 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190200 Reviewed-by: Janice Collins <[email protected]> Reviewed-by: Lasse R.H. Nielsen <[email protected]> Commit-Queue: Janice Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn users when they don't specify a language after the ``` or ~~~ in a fenced code block.