Skip to content

Simplify and fix clean command. #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

davidmorgan
Copy link
Contributor

The previous PR broke the clean command because I removed a timing block and changed the meaning of the early return statements.

On closer inspection, clean can't actually find the asset graph in normal use because the assetGraphPath changes based on the script location, and clean runs from the main script while all the build commands run from the generated build script. So I think clean never actually deleted "generated source files".

So remove that code, including the early return that I broke, and just delete the whole cache folder.

Copy link

PR Health

1 similar comment
Copy link

PR Health

@davidmorgan davidmorgan merged commit 2fc09d9 into dart-lang:master Jun 13, 2025
73 of 75 checks passed
@davidmorgan davidmorgan deleted the clean-command branch June 13, 2025 14:12
@gmpassos
Copy link

gmpassos commented Jun 13, 2025

Just confirming that this has fixed the issue. 👍

Tested with commit:
94d20ff

@davidmorgan
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants