Simplify and fix clean command. #4031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR broke the
clean
command because I removed a timing block and changed the meaning of the earlyreturn
statements.On closer inspection,
clean
can't actually find the asset graph in normal use because theassetGraphPath
changes based on the script location, andclean
runs from the main script while all thebuild
commands run from the generated build script. So I thinkclean
never actually deleted "generated source files".So remove that code, including the early return that I broke, and just delete the whole cache folder.